Back to General discussions forum
Hi!
FYI, im not concerned with spelling right now...
I dont know if this has already been suggested or not. It said on gitHub to post here first so thats what im doing.
My suggestion is that i think users should be able to "star" problems. I sometimes find myself trying to figure out a problem a little too late, and decide to give it up for now and try again the next day. But when tomorrow comes.. that little extra time it takes to find the problem again makes it really easy to choose to not try it again.
Maybe I'm the only one that would find this useful, be able to star problems, maybe they're added to your profile, or just give user the option to sort the problem list after "starred".
I feel like this would be a really good quality of life feature!
Should i post this idea to the list of ideas on gitHub??
Hi Friend!
to give it up for now and try again the next day. But when tomorrow comes..
Do I understand correctly you want to be able to mark problems so they fall into some personal list you want to review later?
Is it enough to have single type of marks (e.g. "star") or more than one type may be needed (but then we'll need some more complicated interface, I see..)
Should i post this idea to the list of ideas on gitHub??
Well, you can if you want to (as I agree it seems a good idea) - but generally github is more for things which couldn't be done quickly. Your suggestion - probably could be done pretty quick, I'll need just think a bit about representation etc, but it shouldn't take years or even weeks :)
Thanks for your answer!
Yes i would say that you understand correctly! Only a single type of mark would suffice I think, like marking a problem as "favorite" with a star, so it falls into either a personal list or users simply just can filter in the big list after "starred"/"favorites" so those are the only problems appearing would be amazing I think!
:)
Hi again!
Thanks for hints and clarifications - as usually even after getting the idea I poorly imagined how better to show "starred" tasks, do they need separate page etc. Showing and filtering them in the main task list is definitely better.
Some initial implementation of your feature is ready - there is a star symbol on the task view page (visible for logged in user) - clicking it toggles "bookmarked" state of the task. They then are marked with "id" field in yellow in the main table (html things it is "gold") - and when sorting mode is "trending" they are groupped above (I was a bit reluctant to add more controls for sorting) - but in other modes they don't change order.
Surely we can further improve and tune all these subtleties about interface (as current idea may be somewhat clumsy/ugly) so feel free to suggest - and of course suggestions are welcome from others who noticed our discussion or the feature itself. At the same time, hopefully, for those who do not use the "starring" almost nothing changed.
UPD: it's me, Rodion, just testing the feature from the user's viewpoint
I definetly agree with you. Simply filtering them like this in the main list is verry efficient and absolutly the way to do it!
Personally this implementation is all i would ever need! And thank you very much for considering my suggestion!
I absolutly dont feel like this implementation becomes too much and is hardly noticed if not used! Wonderful!
Something I realized when testing it is that it is a little "wonky" when unstarring problems. So starring them works great, but when I try to remove the star (by clicking it again) it is still starred in the main list.
just thought id give a headsup about that! :)
+1 I tried this feature out but can't unstar the problem I tried it out on.
Maybe if I solve that problem, the problem goes away? ;)
Eric, Hi and thanks for bringing this up! I obviously missed the previous comment :(
Verily, amusing mistake of mine - I even hardly understand how it could worked when I tested it before. Now hopefully is better!
list of starred problems for user is stored as a comma-separated string, which in the code is "joined" from the
array of task-ids. on removing the "star" code was trying to remove it from this array (using array_splice
) function,
but for some mind eclipse I was reassigning the result of this function call as an updated list of starred ids - this
was wrong as it returns a list of removed elements while array is updated simply because it is passed by reference...